Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vl3 example displaying. #9

Conversation

VitalyGushin
Copy link

@VitalyGushin VitalyGushin commented Feb 8, 2024

#4

cc @denis-tingaikin

After the fix:
Screenshot 2024-02-08 at 17 13 09

Signed-off-by: Vitaliy Guschin <[email protected]>
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please attach a screenshot before/after fix?

@VitalyGushin
Copy link
Author

VitalyGushin commented Feb 8, 2024

Could you please attach a screenshot before/after fix?

Added a screenshot after the fix, before the fix UI was crashing

Vitaliy Guschin added 2 commits February 8, 2024 20:46
Signed-off-by: Vitaliy Guschin <[email protected]>
Signed-off-by: Vitaliy Guschin <[email protected]>
@VitalyGushin VitalyGushin force-pushed the fix-vl3-example-displaying branch from cc33ca4 to c38f225 Compare February 13, 2024 10:15
Signed-off-by: Vitaliy Guschin <[email protected]>
@VitalyGushin VitalyGushin force-pushed the fix-vl3-example-displaying branch from e564791 to 5756253 Compare February 14, 2024 11:09
Signed-off-by: Vitaliy Guschin <[email protected]>
@VitalyGushin VitalyGushin force-pushed the fix-vl3-example-displaying branch from 5756253 to 49574b2 Compare February 14, 2024 11:17
@denis-tingaikin denis-tingaikin merged commit 45be123 into networkservicemesh:main Feb 20, 2024
12 checks passed
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Feb 20, 2024
…d-dashboard-backend@main

PR link: networkservicemesh/cmd-dashboard-backend#9

Commit: 45be123
Author: Denis Tingaikin
Date: 2024-02-20 12:59:10 +0300
Message:
  - Merge pull request #9 from VitalyGushin/fix-vl3-example-displaying
Signed-off-by: NSMBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants